On Sun, 2009-03-08 at 16:27 -0700, Selena Deckelmann wrote:
> ParseConfigFile currently exits on the first parsing error. Changed
> guc_file.l to report all parsing errors before exiting:
> * Moved parse_error: block inside while() loop
> * Removed cleanup_exit: and associated 'goto'
> * Added ereport if ParseConfigFile() returns false
> * changed OK to ok ;)
> * Added comment - TODO: Report bogus variables in addition to parsing
> errors before bailing out
These are very good changes, good news.
Is it possible to check for parameters that have been changed, yet will
not be applied at reload? It's a common error to change something like
shared_buffers and then expect that to have changed when you reload. It
would be useful to issue messages when that has occurred.
-- Simon Riggs www.2ndQuadrant.comPostgreSQL Training, Services and Support
