Re: Updates of SE-PostgreSQL 8.4devel patches (r1704) - Mailing list pgsql-hackers

From Hannu Krosing
Subject Re: Updates of SE-PostgreSQL 8.4devel patches (r1704)
Date
Msg-id 1236675526.8261.5.camel@huvostro
Whole thread Raw
In response to Re: Updates of SE-PostgreSQL 8.4devel patches (r1704)  (KaiGai Kohei <kaigai@ak.jp.nec.com>)
Responses Re: Updates of SE-PostgreSQL 8.4devel patches (r1704)
Re: Updates of SE-PostgreSQL 8.4devel patches (r1704)
List pgsql-hackers
On Tue, 2009-03-10 at 09:56 +0900, KaiGai Kohei wrote:
> Joshua D. Drake wrote:
...
> > Is there any possibility of having it be enabled at compile time? The
> > default would be know but those distributions that would like to make
> > use of it could?
> 
> It was the design a half year ago, but Bruce suggested me a certain
> feature should not be enabled/disabled by compile time options,
> except for library/platform dependency.
>
> In addition, he also suggested
> a feature should be turned on/off by configuration option, because of
> it enables to distribute a single binary for more wider users.
>
> SE-PostgreSQL need the libselinux to communicate the in-kernel SELinux.
> So, --enable-selinux is necessary on compile time, it is fair enough.
> If we omit it, all the sepgsqlXXXX() invocations are replaced by empty
> macros.

seems ok.

Another option to disable it would be something similar to how we
currently handle DTrace ?

> If we compile it with --enable-selinux, it has two working modes
> controled by a guc option: sepostgresql (bool).
> If it is disabled, all the sepgsqlXXXX() invocations returns at
> the head of themself without doing anything.
> 
> I believe this behavior follows the previous suggestion.

Have you been able to measure any speed difference between
--enable-selinux on and off ?

-- 
Hannu Krosing   http://www.2ndQuadrant.com
PostgreSQL Scalability and Availability   Services, Consulting and Training



pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: Prepping to break every past release...
Next
From: Simon Riggs
Date:
Subject: Re: postgresql.conf: patch to have ParseConfigFile report all parsing errors, then bail