Peter Eisentraut - PostgreSQL <petere@hub.org> writes:
> Add dynamic_library_path parameter and automatic appending of shared
> library extension.
Looks good. One tiny nit: I think that DLSUFFIX should be appended if
the given basename doesn't contain any '.', rather than first trying
the name as-is. The problem with doing the latter is that the presence
of a file or subdirectory named "foo" would prevent us from loading
"foo.so" correctly.
Looking ahead, there's a lot of subsidiary work that should now happen:
1. createlang should no longer insert libdir or dlsuffix into the
function declarations it makes (so building createlang from
createlang.sh won't be necessary anymore).
2. Likewise for CREATE FUNCTION commands in regress tests.
3. CREATE FUNCTION documentation should now recommend using relative
path and omitting suffix, rather than using full absolute pathname.
Update examples in SGML docs, src/tutorial/.
Maybe some other places too. Are you planning to do all that, or should
we put it on the to-do list for someone else?
regards, tom lane
