Re: [PATCH] reloptions - RELOPT_KIND_ALL - Mailing list pgsql-hackers

From Zdenek Kotala
Subject Re: [PATCH] reloptions - RELOPT_KIND_ALL
Date
Msg-id 1232796944.1385.24.camel@localhost
Whole thread Raw
In response to Re: [PATCH] reloptions - RELOPT_KIND_ALL  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane píše v pá 23. 01. 2009 v 10:19 -0500:
> Zdenek Kotala <Zdenek.Kotala@Sun.COM> writes:
> > Alvaro Herrera píše v pá 23. 01. 2009 v 11:04 -0300:
> >> Do you have an example use case for this?
> 
> > I use it in my space reservation patch. I going to send it soon.
> 
> Haven't we been over that ground already?  

Maybe I overlooked something, but IIRC that we discussed only TOAST
chunks which is different problem.

> A user-settable reloption
> is not a reasonable solution to a space-reservation problem.  The
> potential for errors of commission and omission is too great.

Hmm, yeah it could be dangerous, but on other side new columns in
pg_class doesn't protect superuser to set incorrect values. I guess that
put constrains on pg_class are not good idea and wrong values could
cause server crash (when reservedspace will be greater then BLCKSZ).
What about reloptions which can be set only by superuser? Or any other
idea?
    Zdenek



pgsql-hackers by date:

Previous
From: Zdenek Kotala
Date:
Subject: Re: foreign_data test fails with non-C locale
Next
From: KaiGai Kohei
Date:
Subject: Re: Time to finalize patches for 8.4 beta