Re: Re: [COMMITTERS] pgsql: Rework subtransaction commit protocol for hot standby. - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: Re: [COMMITTERS] pgsql: Rework subtransaction commit protocol for hot standby.
Date
Msg-id 1225154152.3971.99.camel@ebony.2ndQuadrant
Whole thread Raw
In response to Re: Re: [COMMITTERS] pgsql: Rework subtransaction commit protocol for hot standby.  (Simon Riggs <simon@2ndQuadrant.com>)
Responses Re: Re: [COMMITTERS] pgsql: Rework subtransaction commit protocol for hot standby.
Re: Re: [COMMITTERS] pgsql: Rework subtransaction commit protocol for hot standby.
List pgsql-hackers
On Thu, 2008-10-23 at 19:37 +0100, Simon Riggs wrote:

> I suggest a third version with these changes:
>
> * Write the SUBCOMMITTED to COMMIT transition as a no-op during redo
> rather than as an Assert. This prevents a transition from COMMIT to
> SUBCOMMIT to ABORT. By making it a no-op the attempt to set COMMIT to
> SUBCOMMIT never causes a failure, but it doesn't take place either.
>
> * Disallow SUBCOMMITTED to IN_PROGRESS transition via an Assert.

Even better idea: just use the InRecovery flag. Patch enclosed.

Comments please.

--
 Simon Riggs           www.2ndQuadrant.com
 PostgreSQL Training, Services and Support

Attachment

pgsql-hackers by date:

Previous
From: Kris Jurka
Date:
Subject: Re: Any reason to have heap_(de)formtuple?
Next
From: Tom Lane
Date:
Subject: Re: CREATE TABLE AS WITH NO DATA