Re: CI: Add task that runs pgindent - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: CI: Add task that runs pgindent
Date
Msg-id 12247711-FC64-48A5-B8A5-8989B1490F36@yesql.se
Whole thread Raw
In response to Re: CI: Add task that runs pgindent  (Jelte Fennema-Nio <me@jeltef.nl>)
List pgsql-hackers
> On 23 Oct 2025, at 11:40, Jelte Fennema-Nio <me@jeltef.nl> wrote:
>
> On Wed, 22 Oct 2025 at 14:06, Daniel Gustafsson <daniel@yesql.se> wrote:
>> I like the different shape and symbol, but I would probably keep it green to
>> indicate that it's informational rather than actionable.  We don't want a
>> flurry of patch re-submissions with only whitespace changes eating CI resources
>> when the previous build was successful. Just my €0,02.
>
> I understand the concern. So I tried out making the icon green now
> (see attached), but it looks a bit weird imo. Unless some others
> prefer the green too (or have some other idea for an icon), I'm
> inclined to keep it the yellow/orange color it is now. If we actually
> do get a bunch of useless re-submissions, we can consider changing it.

If the set of icons grows from the self-explanatory red/green we should perhaps
document what the diffent colors mean in the help page?

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Kirill Reshke
Date:
Subject: Re: WIP: parallel GiST index builds
Next
From: Greg Sabino Mullane
Date:
Subject: Re: Proposal: Allow excluding specific file patterns in pg_checksums