AW: Uh, this is *not* a 64-bit CRC ... - Mailing list pgsql-hackers

From Zeugswetter Andreas SB
Subject AW: Uh, this is *not* a 64-bit CRC ...
Date
Msg-id 11C1E6749A55D411A9670001FA68796336821D@sdexcsrv1.f000.d0188.sd.spardat.at
Whole thread Raw
Responses Re: AW: Uh, this is *not* a 64-bit CRC ...  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> I just took a close look at the COMP_CRC64 macro in xlog.c.
> 
> This isn't a 64-bit CRC.  It's two independent 32-bit CRCs, one done
> on just the odd-numbered bytes and one on just the even-numbered bytes
> of the datastream.  That's hardly any stronger than a single 
> 32-bit CRC;
> it's certainly not what I thought we had agreed to implement.

Hmm, strange. I thought that we had agreed upon a 32 bit CRC
on the grounds, that it would be strong enough to guard a single
log record.

Andreas


pgsql-hackers by date:

Previous
From: Tatsuo Ishii
Date:
Subject: Re: SunOS4
Next
From: Olivier PRENANT
Date:
Subject: Re: Re: int8 beta5 broken?