Re: archive_command failures report confusing exit status - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: archive_command failures report confusing exit status
Date
Msg-id 1197393360.4255.1414.camel@ebony.site
Whole thread Raw
In response to Re: archive_command failures report confusing exit status  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: archive_command failures report confusing exit status  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
On Tue, 2007-12-11 at 17:27 +0100, Peter Eisentraut wrote:
> Am Montag, 10. Dezember 2007 schrieb Alvaro Herrera:
> > Peter Eisentraut wrote:
> > > I figured it would make sense if pgarch.c used the same mechanism that
> > > postmaster.c uses to report the various variants of regular and signal
> > > exits.
> >
> > Hmm.  Getting rid of the "(PID 0)" is going to be a mess enough for
> > translations that I think it is worth pgarch.c having its own routine
> > for this.  Furthermore I think the detailed archive command should be
> > reported in an errdetail() field, which makes it even farther off.
> 
> Better patch.

Looks much easier to understand.

I prefer archive_command = ... for the errdetail though. The commands
can be quite long so the extra words don't really add anything, plus
they require translation.

--  Simon Riggs 2ndQuadrant  http://www.2ndQuadrant.com



pgsql-hackers by date:

Previous
From: "Billow Gao"
Date:
Subject: Why my C function is called twice?
Next
From: Tom Lane
Date:
Subject: Re: archive_command failures report confusing exit status