jian he <jian.universality@gmail.com> wrote:
> hi.
> some more minor comments about v13-0001.
>
> GetCommandLogLevel also needs to specify LogStmtLevel for T_RepackStmt?
Fixed in [1].
> /*
> * (CLUSTER might change the order of
> * rows on disk, which could affect the ordering of pg_dump
> * output, but that's not semantically significant.)
> */
> do we need adjust this comment in ClassifyUtilityCommandAsReadOnly
> for the REPACK statement?
Not sure. The current version does not mention VACUUM. (Note that VACUUM FULL
does almost the same as CLUSTER.) We can adjust the comment during the removal
of CLUSTER sometime in the future.
> <para>
> <productname>PostgreSQL</productname> has the ability to report the
> progress of
> certain commands during command execution. Currently, the only commands
> which support progress reporting are <command>ANALYZE</command>,
> <command>CLUSTER</command>,
> <command>CREATE INDEX</command>, <command>VACUUM</command>,
> <command>COPY</command>,
> and <xref linkend="protocol-replication-base-backup"/> (i.e., replication
> command that <xref linkend="app-pgbasebackup"/> issues to take
> a base backup).
> This may be expanded in the future.
> </para>
> also need to mention <command>REPACK</command>?
Fixed in [1].
> "The CLUSTER command is deprecated",
> then do we need to say something
> in doc/src/sgml/ref/clusterdb.sgml?
I'm not convinced at the moment. The page contains a link to the documentation
of CLUSTER, which does contain the deprecation note.
It's not even clear to me whether this utility must be removed. We can adjust
it so it calls REPACK instead of CLUSTER. And while doing that, we may or may
not rename it.
[1] https://www.postgresql.org/message-id/117560.1749464355%40localhost
--
Antonin Houska
Web: https://www.cybertec-postgresql.com
