Re: Reviewers Guide to Deferred Transactions/TransactionGuarantee - Mailing list pgsql-patches

From Simon Riggs
Subject Re: Reviewers Guide to Deferred Transactions/TransactionGuarantee
Date
Msg-id 1176022006.3623.630.camel@silverbirch.site
Whole thread Raw
In response to Reviewers Guide to Deferred Transactions/Transaction Guarantee  ("Simon Riggs" <simon@2ndquadrant.com>)
Responses Re: Reviewers Guide to Deferred Transactions/TransactionGuarantee  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: Reviewers Guide to Deferred Transactions/TransactionGuarantee  (ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp>)
Re: Reviewers Guide to Deferred Transactions/TransactionGuarantee  (Bruce Momjian <bruce@momjian.us>)
List pgsql-patches
On Thu, 2007-04-05 at 22:56 +0100, Simon Riggs wrote:
> transaction_guarantee.v11.patch

correct files attached

> Open Questions
> --------------
>
> 1. Should the DFC use a standard hash table? Custom code allows both
> additional speed and the ability to signal when it fills.
>
> 2. Should tqual.c update the LSN of a heap page with the LSN of the
> transaction commit that it can read from the DF cache?

I now think we should update the LSN of the page, but not changed yet.

> 3. Should the WALWriter also do the wal_buffers half-full write at the
> start of XLogInsert() ?

Not that important

> 4. The recent changes to remove CheckpointStartLock haven't changed the
> code path for deferred transactions, so a similar solution might be
> possible there also.

Some further discussion required here, I think. That change may actually
have introduced a slight risk into the patch. Will raise at review.

> 5. Is it correct to do WAL-before-flush for clog only, or should this
> be multixact also?

Not necessary

--
  Simon Riggs
  EnterpriseDB   http://www.enterprisedb.com


Attachment

pgsql-patches by date:

Previous
From: "Simon Riggs"
Date:
Subject: Re: Heap page diagnostic/test functions (v2)
Next
From: Tom Lane
Date:
Subject: Re: Reviewers Guide to Deferred Transactions/TransactionGuarantee