Re: BUG #12779: pg_dump -Fd doesn't care about -Z - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #12779: pg_dump -Fd doesn't care about -Z
Date
Msg-id 11740.1424277913@sss.pgh.pa.us
Whole thread Raw
In response to Re: BUG #12779: pg_dump -Fd doesn't care about -Z  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-bugs
Michael Paquier <michael.paquier@gmail.com> writes:
> On Wed, Feb 18, 2015 at 3:52 AM, Tom Lane wrote:
>> This doesn't look tremendously hard to fix, but it's not a one-liner
>> either.  Don't have time for it personally right now.

> Interesting. The call to gzopen is missing the compression level,
> always passing either 'w' or 'wb', while for example to write with a
> compression level of 6 we should pass w6 or wb6.

> The patch attached addresses that.

Committed.  I also fixed another problem in this code, which was an
overoptimistic assumption that free() doesn't change errno; we've heard
that it can on OS X at least.  That would've resulted in faulty error
reports for file-open failures.

            regards, tom lane

pgsql-bugs by date:

Previous
From: patl659in@rediffmail.com
Date:
Subject: BUG #12782: Some abnormal observation about the to_date() function in greenplum database
Next
From: Tom Lane
Date:
Subject: Re: BUG #12782: Some abnormal observation about the to_date() function in greenplum database