Re: Fast CLUSTER - Mailing list pgsql-patches

From Simon Riggs
Subject Re: Fast CLUSTER
Date
Msg-id 1172184550.3874.196.camel@silverbirch.site
Whole thread Raw
In response to Re: Fast CLUSTER  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: Fast CLUSTER
Re: Fast CLUSTER
Re: Fast CLUSTER
List pgsql-patches
On Tue, 2007-02-20 at 14:38 -0300, Alvaro Herrera wrote:

> Cool.  I noticed that the SGML seems broken here:

Corrected.

> You need to close the <listitem> and <para> opened in the COPY mention.
>
> > +
> > + static void
> > + heap_sync_relation(Relation rel)
> > + {
> > +     if (!rel->rd_istemp)
>
> No comment in this function?

I've added more comments as you suggest.

Thanks for the review.

--
  Simon Riggs
  EnterpriseDB   http://www.enterprisedb.com


Attachment

pgsql-patches by date:

Previous
From: "Guillaume Smet"
Date:
Subject: Re: First implementation of GIN for pg_trgm
Next
From: "Jim C. Nasby"
Date:
Subject: Re: [HACKERS] HOT WIP Patch - version 2