Hello
Could you rebase patch please? I have errors during patch apply. CFbot checks latest demonstration patch.
> I looked into this. It seems trivial to make walsender create and use a
> temporary replication slot by default if no permanent replication slot
> is specified. This is basically the logic that pg_basebackup has but
> done server-side. See attached patch for a demonstration. Any reason
> not to do that?
Seems this would break pg_basebackup --no-slot option?
> + Do not copy configuration files, that is, files that end in
> + <filename>.conf</filename>.
possible we need ignore *.signal files too?
> +/*
> + * XXX copied from pg_basebackup.c
> + */
> +
> +unsigned long long totaldone;
> +unsigned long long totalsize_kb;
> +int tablespacenum;
> +int tablespacecount;
Variable declaration in the middle of file is correct for coding style? Not a problem for me, I just want to clarify.
Should not be declared "static"?
Also how about tablespacedone instead of tablespacenum?
> The updated has support for tablespaces without mapping. I'm thinking
> about putting the mapping specification into a GUC list somehow.
> Shouldn't be too hard.
I think we can leave tablespace mapping for pg_basebackup only. More powerful tool for less common scenarios. Or for
anotherfuture patch.
regards, Sergei
