Re: Uncleared result sets in describeOneTableDetails() - Mailing list pgsql-hackers

From Neil Conway
Subject Re: Uncleared result sets in describeOneTableDetails()
Date
Msg-id 1162906925.25857.20.camel@localhost.localdomain
Whole thread Raw
In response to Re: Uncleared result sets in describeOneTableDetails()  ("Brendan Jurd" <direvus@gmail.com>)
List pgsql-hackers
On Tue, 2006-11-07 at 17:56 +1100, Brendan Jurd wrote:
> It certainly isn't pretty.  It's been a long time since I looked down
> the barrel of a 'goto'.

I don't think there's anything wrong with using "goto" for error
handling in this style. Personally, I think the main stylistic problem
is that the function is 600 lines long: it would be a lot cleaner if
refactored into smaller functions with smaller individual scopes.

-Neil




pgsql-hackers by date:

Previous
From: Martijn van Oosterhout
Date:
Subject: Re: Index ignored with "is not distinct from", 8.2 beta2
Next
From: "Gurjeet Singh"
Date:
Subject: Found a bug