Re: patch fixing the old RETURN NEXT bug - Mailing list pgsql-patches

From Neil Conway
Subject Re: patch fixing the old RETURN NEXT bug
Date
Msg-id 1140393584.2615.13.camel@localhost.localdomain
Whole thread Raw
In response to patch fixing the old RETURN NEXT bug  ("Sergey E. Koposov" <math@sai.msu.ru>)
Responses Re: patch fixing the old RETURN NEXT bug
List pgsql-patches
On Sun, 2006-02-12 at 20:15 +0300, Sergey E. Koposov wrote:
> I'm proposing the fix of this bug:
> http://archives.postgresql.org/pgsql-hackers/2005-02/msg00498.php

I think the suggested logic for compatible_tupdesc() is still wrong. For
example, the patch rejects the following:

create table usno (ra real, dec real, bmag real, rmag real, ipix int8);
create function ret_next_check() returns setof usno as $$
declare
    r record;
begin
    for r in select * from usno loop
        return next r;
    end loop;
    return;
end;
$$ language plpgsql;

insert into usno values (1.0, 2.0, 3.0, 4.0, 5);
select * from ret_next_check();
alter table usno drop column ipix;
select * from ret_next_check(); -- fails, should succeed

Also, this patch should include updates to the regression tests.

-Neil



pgsql-patches by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: implement prepared queries in plperl
Next
From: James William Pye
Date:
Subject: ScanDirections