Re: pgsql: Add psql option: -1 or --single-transaction - Mailing list pgsql-committers

From Simon Riggs
Subject Re: pgsql: Add psql option: -1 or --single-transaction
Date
Msg-id 1139957492.1258.1038.camel@localhost.localdomain
Whole thread Raw
In response to Re: pgsql: Add psql option: -1 or --single-transaction  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Add psql option: -1 or --single-transaction  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On Tue, 2006-02-14 at 12:32 -0500, Tom Lane wrote:
> Simon Riggs <simon@2ndquadrant.com> writes:
> > Just put an if test around that blob-handling behaviour. The code looks
> > very simple, so patch enclosed to augment the already-applied patch.
>
> Isn't the end-restore test backwards?

Corrected in enclosed patch. Another problem found and fixed also.

> > Chris, do you have a set-up to test out the blob behaviour?
>
> Just do a couple of lo_imports into a test database, dump, look at
> pg_restore's output to see if it's sane ...

Tests pass. BEGIN/COMMIT in correct places in log files (included).

Tests enclosed:
without single transaction
./test.sh > 0.log

with single transaction
./test.sh -1 > 1.log

Also tested with direct database connection, which works both in error
and success. [My earlier problem was a library version mismatch from the
recent update of the COPY protocol, thankfully.]

Best Regards, Simon Riggs

Attachment

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Move btbulkdelete's vacuum_delay_point()
Next
From: agoldshuv@pgfoundry.org (User Agoldshuv)
Date:
Subject: bizgres - bizgres: Updated version number to 2.0.13