PG_PAGE_LAYOUT_VERSION - Should be Documented as 3? - Mailing list pgsql-hackers

From Matt Miller
Subject PG_PAGE_LAYOUT_VERSION - Should be Documented as 3?
Date
Msg-id 1125588973.3636.10.camel@dbamm01-linux
Whole thread Raw
Responses Re: PG_PAGE_LAYOUT_VERSION - Should be Documented as 3?
Re: PG_PAGE_LAYOUT_VERSION - Should be Documented as 3?
List pgsql-hackers
doc/src/sgml/storage.sgml says:

"The last 2 bytes of the page header,
<structfield>pd_pagesize_version</structfield>, store both the page size
and a version indicator.  Beginning with
<productname>PostgreSQL</productname> 8.0 the version number is 2;
<productname>PostgreSQL</productname> 7.3 and 7.4 used version number 1;
prior releases used version number 0."

But src/include/storage/bufpage.h says:

"/*
 * Page layout version number 0 is for pre-7.3 Postgres releases.
 * Releases 7.3 and 7.4 use 1, denoting a new HeapTupleHeader layout.
 * Release 8.0 changed the HeapTupleHeader layout again.
 * Release 8.1 redefined HeapTupleHeader infomask bits.
 */
#define PG_PAGE_LAYOUT_VERSION      3"

So, should the attached be applied?

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: On hardcoded type aliases and typmod for user types
Next
From: Andrew - Supernews
Date:
Subject: Re: TODO item: set proper permissions on non-system schemas