Re: WIP: pl/pgsql cleanup - Mailing list pgsql-patches

From Neil Conway
Subject Re: WIP: pl/pgsql cleanup
Date
Msg-id 1106269781.22946.260.camel@localhost.localdomain
Whole thread Raw
In response to Re: WIP: pl/pgsql cleanup  (Neil Conway <neilc@samurai.com>)
List pgsql-patches
On Thu, 2005-01-20 at 15:48 +1100, Neil Conway wrote:
> Attached is a revised patch (no major changes, just grammar cleanup).
> While rewriting some cruft in PL/PgSQL's gram.y, I noticed that we will
> overflow a heap-allocated array if the user specifies more than 1024
> parameters to a refcursor (a demonstration .sql file is also attached).
> I think this is probably worth backpatching to 8.0 (and earlier?) --
> I've attached a quick hack of a patch that fixes the issue, although of
> course the fix for 8.1 is nicer.

I've applied the minimal fix for the buffer overrun to REL7_4_STABLE and
REL8_0_STABLE (let me know if you think it's worth backpatching
further).

I'll post a revised patch for HEAD that does the falloc() stuff soon.

-Neil



pgsql-patches by date:

Previous
From: Neil Conway
Date:
Subject: regression: pass with no default WITH OIDS
Next
From: Euler Taveira de Oliveira
Date:
Subject: Re: uptime function to postmaster