Re: Mark all GUC variable as PGDLLIMPORT - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Mark all GUC variable as PGDLLIMPORT
Date
Msg-id 107887.1629728571@sss.pgh.pa.us
Whole thread Raw
In response to Mark all GUC variable as PGDLLIMPORT  (Julien Rouhaud <rjuju123@gmail.com>)
Responses Re: Mark all GUC variable as PGDLLIMPORT  (Julien Rouhaud <rjuju123@gmail.com>)
List pgsql-hackers
Bruce Momjian <bruce@momjian.us> writes:
> On Mon, Aug 23, 2021 at 10:15:04AM -0400, Tom Lane wrote:
>> By that argument, *every* globally-visible variable should be marked
>> PGDLLIMPORT.  But the mere fact that two backend .c files need to access

> No, Julien says 99% need only the GUCs, so that is not the argument I am
> making.

That's a claim unbacked by any evidence that I've seen.  More to
the point, we already have a mechanism that extensions can/should
use to read and write GUC settings, and it's not direct access.

            regards, tom lane



pgsql-hackers by date:

Previous
From: vignesh C
Date:
Subject: Re: Added schema level support for publication.
Next
From: Alvaro Herrera
Date:
Subject: Re: Queries that should be canceled will get stuck on secure_write function