Re: fix log_min_duration_statement logic error - Mailing list pgsql-patches

From Rod Taylor
Subject Re: fix log_min_duration_statement logic error
Date
Msg-id 1065380730.23288.190.camel@jester
Whole thread Raw
In response to Re: fix log_min_duration_statement logic error  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: fix log_min_duration_statement logic error
List pgsql-patches
> > I have not heard from you why we should make it harder (split across two
> > lines), except for consistency with log_statement and log_duration
> > outputs.

I think this is a perfectly good argument. Don't make writing the tools
to parse the log more difficult than necessary.

Rather than making the log files look nice, lets add a module to PgAdmin
that can read it and display it in a user friendly manner (with
abilities like sorting queries by execution time!).

> Should we instead convert newlines to "\n" and output the query as a
> single line?  Do we have lots of other multi-line outputs in the log
> files?

Please don't. Or if you do, don't data unless you intend to escape
special characters (in this case \) at the same time so we can convert
it back to the original state.

Attachment

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: fix log_min_duration_statement logic error
Next
From: Bruce Momjian
Date:
Subject: Re: fix log_min_duration_statement logic error