Re: Why don't we have a small reserved OID range for patch revisions? - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Why don't we have a small reserved OID range for patch revisions?
Date
Msg-id 10547.1549650560@sss.pgh.pa.us
Whole thread Raw
In response to Re: Why don't we have a small reserved OID range for patch revisions?  (Peter Geoghegan <pg@bowt.ie>)
Responses Re: Why don't we have a small reserved OID range for patch revisions?
Re: Why don't we have a small reserved OID range for patch revisions?
List pgsql-hackers
Peter Geoghegan <pg@bowt.ie> writes:
> On Fri, Feb 8, 2019 at 10:14 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> A script such as you suggest might be a good way to reduce the temptation
>> to get lazy at the last minute.  Now that the catalog data is pretty
>> machine-readable, I suspect it wouldn't be very hard --- though I'm
>> not volunteering either.  I'm envisioning something simple like "renumber
>> all OIDs in range mmmm-nnnn into range xxxx-yyyy", perhaps with the
>> ability to skip any already-used OIDs in the target range.

> I imagined that the machine-readable catalog data would allow us to
> assign non-numeric identifiers to this OID range. Perhaps there'd be a
> textual symbol with a number in the range of 0-20 at the end. Those
> would stick out like a sore thumb, making it highly unlikely that
> anybody would forget about it at the last minute.

Um.  That would not be just an add-on script but something that
genbki.pl would have to accept.  I'm not excited about that; it would
complicate what's already complex, and if it works enough for test
purposes then it wouldn't really stop a committer who wasn't paying
attention from committing the patch un-revised.

To the extent that this works at all, OIDs in the 9000 range ought
to be enough of a flag already, I think.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Brandur Leach
Date:
Subject: Re: Patch for SortSupport implementation on inet/cdir
Next
From: Peter Geoghegan
Date:
Subject: Re: Why don't we have a small reserved OID range for patch revisions?