Postgres Pro
Downloads
Home   >   mailing lists

Re: Vintage unused variables in pg_dump.c - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Vintage unused variables in pg_dump.c
Date
Msg-id 1036.1589822558@sss.pgh.pa.us
Whole thread Raw
In response to Vintage unused variables in pg_dump.c  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
Tree view 
Daniel Gustafsson <daniel@yesql.se> writes:
> Unless I'm missing something, the g_comment_start and g_comment_end variables
> in pg_dump.c seems to have been unused since 30ab5bd43d8f2082659191 (in the 7.2
> cycle) and can probably be safely removed by now.

Indeed.  (Well, I didn't verify your statement about when they were
last used, but they're clearly dead now.)  Pushed.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Missing grammar production for WITH TIES
Next
From: Ranier Vilela
Date:
Subject: Re: Why is pq_begintypsend so slow?