Re: Re: [COMMITTERS] pgsql: pgbench: Allow the transaction log file prefix to be changed. - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Re: [COMMITTERS] pgsql: pgbench: Allow the transaction log file prefix to be changed.
Date
Msg-id 10286.1478747286@sss.pgh.pa.us
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: pgbench: Allow the transaction log file prefix to be changed.  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Re: [COMMITTERS] pgsql: pgbench: Allow the transaction log file prefix to be changed.  (Michael Paquier <michael.paquier@gmail.com>)
Re: Re: [COMMITTERS] pgsql: pgbench: Allow the transaction log file prefix to be changed.  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Wed, Nov 9, 2016 at 4:51 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Perhaps the "logpath" buffer that the filename is constructed in
>> needs to be made bigger.  64 bytes was obviously enough with the
>> old pattern, but it's not with the new.

> Oops, yes, that seems like a good idea.  How about 64 -> MAXPGPATH?

If we want to stick with the fixed-size-buffer-on-stack approach,
that would be the thing to use.  psprintf is another possibility,
though that would add a malloc/free cycle.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: Declarative partitioning - another take
Next
From: Michael Paquier
Date:
Subject: Re: Re: [COMMITTERS] pgsql: pgbench: Allow the transaction log file prefix to be changed.