Re: [HACKERS] pg_dump vs. TRANSFORMs - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] pg_dump vs. TRANSFORMs
Date
Msg-id 10157.1481235656@sss.pgh.pa.us
Whole thread Raw
In response to Re: pg_dump vs. TRANSFORMs  (Stephen Frost <sfrost@snowman.net>)
Responses Re: [HACKERS] pg_dump vs. TRANSFORMs
Re: [HACKERS] pg_dump vs. TRANSFORMs
List pgsql-hackers
Stephen Frost <sfrost@snowman.net> writes:
> That's a good point, we might be doing things wrong in other places in
> the code by using FirstNormalObjectId on pre-8.1 servers.

> What I suggest then is an independent patch which uses a different
> variable than FirstNormalObjectId and sets it correctly based on the
> version of database that we're connecting to,

+1

> and after that's working
> correctly for HEAD vs. HEAD-8.0, and 9.6-9.2 vs. 9.6-7.1 (all I was able
> to get running within a few hours..  if someone wants to test against
> 7.0 or earlier that's fine, or if someone can provide a clean patch to
> make 7.0 work for me, that's fine too) and after that looks good and is
> committed, I'll rebase this work on that.

pg_dump never intended to support pre-7.0 servers.  I do have 7.0-7.3
servers in captivity and can do testing if you like.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] Changed SRF in targetlist handling
Next
From: Robert Haas
Date:
Subject: Re: [HACKERS] Performance degradation in Bitmapscan (commit 75ae538bc3168bf44475240d4e0487ee2f3bb376)