Re: lz4 --rm on Ubuntu 18.04 (Add LZ4 compression to pg_dump) - Mailing list pgsql-hackers

From Tomas Vondra
Subject Re: lz4 --rm on Ubuntu 18.04 (Add LZ4 compression to pg_dump)
Date
Msg-id 0e8e53fa-5087-2151-dcd6-a1d3ad3ed493@enterprisedb.com
Whole thread Raw
In response to Re: lz4 --rm on Ubuntu 18.04 (Add LZ4 compression to pg_dump)  (Michael Paquier <michael@paquier.xyz>)
Responses Re: lz4 --rm on Ubuntu 18.04 (Add LZ4 compression to pg_dump)  (Tomas Vondra <tomas.vondra@enterprisedb.com>)
List pgsql-hackers

On 3/9/23 01:30, Michael Paquier wrote:
> On Thu, Mar 09, 2023 at 12:39:08AM +0100, Tomas Vondra wrote:
>> IMO we should fix that. We have a bunch of buildfarm members running on
>> Ubuntu 18.04 (or older) - it's true none of them seems to be running TAP
>> tests. But considering how trivial the fix is ...
>>
>> Barring objections, I'll push a fix early next week.
> 
> +1, better to change that, thanks.  Actually, would --rm be OK even on
> Windows?  As far as I can see, the CI detects a LZ4 command for the
> VS2019 environment but not the liblz4 libraries that would be needed
> to trigger the set of tests.

Thanks for noticing that. I'll investigate next week.


regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: improving user.c error messages
Next
From: Jim Jones
Date:
Subject: Re: [PATCH] Add pretty-printed XML output option