Re: Propagate XLogFindNextRecord error to callers - Mailing list pgsql-hackers

From Mircea Cadariu
Subject Re: Propagate XLogFindNextRecord error to callers
Date
Msg-id 0cbf5d34-f117-456f-bcc0-50fa9a8eafba@gmail.com
Whole thread Raw
In response to Propagate XLogFindNextRecord error to callers  (Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>)
List pgsql-hackers
Hi Anthonin,

On 12/12/2025 10:39, Anthonin Bonnefoy wrote:
>
> With this patch, pg_waldump will now have the following output when 
> reading a file with an invalid header:
> pg_waldump: error: could not find a valid record after D80/5C000000: 
> invalid magic number D116 in WAL segment 0000001400000D8000000017, LSN 
> D80/5C000000, offset 0

I've picked up the review for your patch.

Attached is a failing test that reproduces the issue. Have I got it 
right? We can consider using it to validate your patch then.

-- 
Thanks,
Mircea Cadariu

Attachment

pgsql-hackers by date:

Previous
From: Srirama Kucherlapati
Date:
Subject: RE: AIX support
Next
From: Andres Freund
Date:
Subject: Odd code around ginScanToDelete