Request a Demo
Home   >   mailing lists

Propagate XLogFindNextRecord error to callers - Mailing list pgsql-hackers

From Anthonin Bonnefoy
Subject Propagate XLogFindNextRecord error to callers
Date
Msg-id CAO6_XqoxJXddcT4wkd9Xd+cD6Sz-fyspRGuV4Bq-wbXG4pVNzA@mail.gmail.com
Whole thread Raw
List pgsql-hackers
Tree view
Hi,

Currently, XLogFindNextRecord errormsg is ignored and callers will only output a generic 'could not find a valid record' message without details.
Additionally, invalid page header won't go through XLogReadRecord, leaving the error in state->errormsg_buf.

This patch propagates XLogFindNextRecord's error message to the callers and displays it. In case of an invalid page header, the errormsg is filled with errormsg_buf content.

With this patch, pg_waldump will now have the following output when reading a file with an invalid header:
pg_waldump: error: could not find a valid record after D80/5C000000: invalid magic number D116 in WAL segment 0000001400000D8000000017, LSN D80/5C000000, offset 0 

Regards,
Anthonin Bonnefoy
Attachment

pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: Fix memory leak in gist_page_items() of pageinspect
Next
From: Akshay Joshi
Date:
Subject: Re: [PATCH] Add pg_get_database_ddl() function to reconstruct CREATE DATABASE statement