On 13/02/2019 16:40, Andres Freund wrote:
> On February 13, 2019 4:39:21 PM GMT+01:00, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
>> On 13/02/2019 13:18, Andres Freund wrote:
>>> But I don't think the way you did it is acceptable - we can't just
>> delay while holding buffer locks, in critical sections, while not
>> interruptible.
>>
>> The code I added to XLogInsertRecord() is not inside the critical
>> section.
>
> Most callers do xlog insertions inside crit sections though.
Is it a problem that pg_usleep(CommitDelay) is inside a critical section?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
