Re: Warning is adjusted of pgbench. - Mailing list pgsql-patches

From Hiroshi Saito
Subject Re: Warning is adjusted of pgbench.
Date
Msg-id 0b2301c7ffec$f2282370$c601a8c0@HP22720319231
Whole thread Raw
In response to Warning is adjusted of pgbench.  ("Hiroshi Saito" <z-saito@guitar.ocn.ne.jp>)
List pgsql-patches
Hi.

From: "Tom Lane" <tgl@sss.pgh.pa.us>


> "Hiroshi Saito" <z-saito@guitar.ocn.ne.jp> writes:
>> From: "Tom Lane" <tgl@sss.pgh.pa.us>
>>> Perhaps instead postgres_fe.h should #define FRONTEND?
>
>> Yes,  I feared that the physique of a main part broke. Then, Magnus said the
>> same suggestion as you. It seems that it needs to be brushup.
>> I am going to improve by the reason referred to as that FRONTEND influences
>> nmake (libpq) again. Probably, Mugnus is operating main part.?
>
> To be clear: my thought is to put "#define FRONTEND 1" into
> postgres_fe.h and then eliminate ad-hoc definitions of it from a
> boatload of Makefiles.  A quick grep suggests that the only place this
> wouldn't work too well is src/port/, but that could keep on doing what
> it's doing.

I think sufficient suggestion.

>
> I'm not in a good position to test this, because it will mainly matter
> on Windows which I don't do.  Anyone else have a chance to try it?

I want, will try it. of course, work of Magnus is not barred.
Thanks!

Regards,
Hiroshi Saito

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: Warning is adjusted of pgbench.
Next
From: ITAGAKI Takahiro
Date:
Subject: Re: Thread-safe PREPARE in ecpg