Amit-san,
On Tue, Mar 12, 2019 at 2:34 PM, Amit Langote wrote:
> Thanks for the heads up.
>
> On Tue, Mar 12, 2019 at 10:23 PM Jesper Pedersen
> <jesper.pedersen@redhat.com> wrote:
> > After applying 0004 check-world fails with the attached. CFBot agrees
> [1].
>
> Fixed. I had forgotten to re-run postgres_fdw tests after making a change
> just before submitting.
I have done code review of v31 patches from 0001 to 0004.
I described below what I confirmed or thoughts.
0001: This seems ok.
0002:
* I don't really know that delaying adding resjunk output columns to the plan doesn't affect any process in the
planner.From the comments of PlanRowMark, those columns are used in only the executor so I think delaying adding junk
Varswouldn't be harm, is that right?
0003:
* Is there need to do CreatePartitionDirectory() if rte->inh becomes false?
+ else if (rte->rtekind == RTE_RELATION && rte->inh)
+ {
+ rte->inh = has_subclass(rte->relid);
+
+ /*
+ * While at it, initialize the PartitionDesc infrastructure for
+ * this query, if not done yet.
+ */
+ if (root->glob->partition_directory == NULL)
+ root->glob->partition_directory =
+ CreatePartitionDirectory(CurrentMemoryContext);
+ }
0004:
* In addition to commit message, this patch also changes the method of adjusting AppendRelInfos which reference to the
subqueryRTEs, and new one seems logically correct.
* In inheritance_planner(), we do ChangeVarNodes() only for orig_rtable, so the codes concatenating lists of
append_rel_listmay be able to be moved before doing ChangeVarNodes() and then the codes concatenating lists of
rowmarks,rtable and append_rel_list can be in one block (or one bunch).
--
Yoshikazu Imai
