Re: Move SLRU_PAGES_PER_SEGMENT to pg_config_manual.h - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Move SLRU_PAGES_PER_SEGMENT to pg_config_manual.h
Date
Msg-id 0D7A4044-3E31-4AB0-8DA7-54A805B2913C@yesql.se
Whole thread Raw
In response to Move SLRU_PAGES_PER_SEGMENT to pg_config_manual.h  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-hackers
> On 10 Nov 2025, at 12:29, Heikki Linnakangas <hlinnaka@iki.fi> wrote:

> There was a suggestion earlier to make SLRU_PAGES_PER_SEGMENT a configure option [2]. I don't want to go that far;
pg_config_manual.hseems like the right level of configurability to me. 

Agreed.  The thread referenced above never really answered why a configure time
option would be needed.

+    uint32        slru_pages_per_segment; /* size of each SLRU segment */

Should this be expanded ever so slightly?  A new reader of the code might
wonder about the relationship between "pages_per" and "size".

No objections (apart from the catversion =)) from reading the patch.

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Álvaro Herrera
Date:
Subject: Re: Remove unused for_all_tables field from AlterPublicationStmt
Next
From: Daniel Gustafsson
Date:
Subject: Re: Fix a typo in the comment for gettuple_eval_partition()