RE: [bug fix??] Fishy code in tts_cirtual_copyslot() - Mailing list pgsql-hackers

From Tsunakawa, Takayuki
Subject RE: [bug fix??] Fishy code in tts_cirtual_copyslot()
Date
Msg-id 0A3221C70F24FB45833433255569204D1FD49C48@G01JPEXMBYT05
Whole thread Raw
In response to Re: [bug fix??] Fishy code in tts_cirtual_copyslot()  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
From: Tom Lane [mailto:tgl@sss.pgh.pa.us]
> I temporarily changed the Assert to be "==" rather than "<=", and
> it still passed check-world, so evidently we are not testing any
> cases where the descriptors are of different lengths.  This explains
> the lack of symptoms.  It's still a bug though, so pushed.

Thank you for committing.

> > BTW, I thought that in PostgreSQL coding convention, local variables
> should be defined at the top of blocks, but this function writes "for (int
> natts;".
> 
> Yeah, we've agreed to join the 21st century to the extent of allowing
> local for-loop variables.

That's good news.  It'll help a bit to code comfortably.


Regards
Takayuki Tsunakawa






pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Cache lookup errors with functions manipulation object addresses
Next
From: Peter Geoghegan
Date:
Subject: Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index.