Re: [HACKERS] Supporting huge pages on Windows - Mailing list pgsql-hackers

From Tsunakawa, Takayuki
Subject Re: [HACKERS] Supporting huge pages on Windows
Date
Msg-id 0A3221C70F24FB45833433255569204D1F6712DF@G01JPEXMBYT05
Whole thread Raw
In response to Re: [HACKERS] Supporting huge pages on Windows  (Thomas Munro <thomas.munro@enterprisedb.com>)
List pgsql-hackers
From: Thomas Munro [mailto:thomas.munro@enterprisedb.com]
> In the Microsoft documentation I've seen, the privilege's name is always
> written as "Lock Pages in Memory" (note: "Pages" plural, and with initial
> capital letters).  It's quite hard to parse the sentence otherwise!  How
> about this?
> 
>          Huge pages are known as large pages on Windows.  To use them, you
> need to
>          assign the user right Lock Pages in Memory to the Windows user
> account
>          that runs <productname>PostgreSQL</productname>.
> 
> + ereport(elevel,
> + (errmsg("could not enable Lock pages in memory user right: error
> code %lu", GetLastError()),
> + errdetail("Failed system call was OpenProcessToken.")));
> 
> Same comment about capitalisation of the privilege name in this and other
> error messages.

Thanks, your sentences are surely better.  Fixed.

Regards
Takayuki Tsunakawa


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachment

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] pg_stat_activity.waiting_start
Next
From: Andrew Gierth
Date:
Subject: [HACKERS] Hash support for grouping sets