> On Nov 24, 2025, at 08:59, Chao Li <li.evan.chao@gmail.com> wrote:
>
> I will proceed 0007 tomorrow.
I just finished reviewing 0007 and 0008. This patch set really demonstrates the full lifecycle of adding a SQL feature,
fromchanging the syntax in gram.y all the way down to the executor, including tests and docs. I learned a lot from it.
Thanks!
23 - 0007
As you mentioned earlier, pattern regular expression support *, + and ?, but I don’t see ? is tested.
24 - 0007
I don’t see negative tests for unsupported quantifiers, like PATTERN (A+?).
25 - 0007
```
+-- basic test with none greedy pattern
```
Typo: “none greedy” -> non-greedy
No comment for 0008.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
