Re: Server instrumentation patch - Mailing list pgsql-hackers

From Michael Paesold
Subject Re: Server instrumentation patch
Date
Msg-id 02f201c578d4$14f4baf0$0f01a8c0@zaphod
Whole thread Raw
In response to Re: Server instrumentation patch  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: Server instrumentation patch
List pgsql-hackers
Andreas Pflug wrote:

>>For the second, please supply a patch that moves _all_ of dbsize into
>>the main server.  I think we have agreement on that.
>>
>
> I don't think so. As I mentioned, those views are broken. Do you want them 
> to be in core anyway?

Why is e.g. this one broken:
int8 database_size(name) - Return the size of the database in
bytes (by name)

It should do the same as the one with the oid except that it will resolve 
the name first, no? If not it should be fixed, not dropped. I understand 
you'd like to have those functions for the GUI frontends, but what about 
psql users? For many people it will be hard work to type the subquery to get 
the database oid.

I vote for all (possibly corrected) functions to be moved into core.

Best Regards,
Michael Paesold 



pgsql-hackers by date:

Previous
From: "Mark Cave-Ayland"
Date:
Subject: Re: Fixing r-tree semantics
Next
From: Tom Lane
Date:
Subject: Re: [PATCHES] Function's LEAST, GREATEST and DECODE (Oracle vararg polymorphic functions)