Re: bytea_ops - Mailing list pgsql-patches

From Joe Conway
Subject Re: bytea_ops
Date
Msg-id 01c601c122f7$d9fd57d0$0705a8c0@jecw2k1
Whole thread Raw
In response to bytea_ops  ("Joe Conway" <joseph.conway@home.com>)
Responses Re: bytea_ops  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Here's a new patch.

> Looks like you missed one VarChar -> bytea.

Fixed.

> I think it's better style to code stuff like this as
>
> PG_RETURN_BOOL((cmp < 0) || ((cmp == 0) && (len1 < len2)));

Done.

> The biggie is that you missed adding support for bytea to scalarltsel,
> which puts a severe crimp on the optimizer's ability to make any
> intelligent decisions about using your index.

Hopefully done correctly ;-)


-- Joe


Attachment

pgsql-patches by date:

Previous
From: "Joe Conway"
Date:
Subject: Re: bytea_ops
Next
From: Tom Lane
Date:
Subject: Re: bytea_ops