On Monday, September 17, 2012 1:39 AM Jeff Janes wrote:
On Wed, Jul 4, 2012 at 7:38 AM, Amit Kapila <amit.kapila@huawei.com> wrote:
> From: Robert Haas [mailto:robertmhaas@gmail.com]
> Sent: Tuesday, July 03, 2012 9:43 PM
> On Mon, Jul 2, 2012 at 8:08 AM, Amit Kapila <amit.kapila@huawei.com>
wrote:
>>>> Suggestions?
>
>>> I suggest you add this to the next CommitFest. :-)
>
>>> https://commitfest.postgresql.org/action/commitfest_view?id=14
>
>>> Meanwhile, we have this CommitFest to get finished with...
>
>> I shall add it to next CF.
> I put my self down as a reviewer for this a while ago, but I never got
> beyond the stage of verifying that it applies and compiles, and that
> it does what it says it does, at least in the broad sense, and that
> what it does is desirable (I think it is).
> I haven't done a detailed code review, or tested for corner cases.
> Unfortunately I don't think I'll be able to do either of those during
> this commitfest, or at least not until toward the end of it. So I
> took myself off as reviewer so the commit-fest manager can assign
> someone else. Sorry about that.
Thank you for confirming the sanity of patch at broad level.
With Regards,
Amit Kapila.