Re: 7.3 and HEAD broken for dropped columns of dropped types - Mailing list pgsql-hackers

From Christopher Kings-Lynne
Subject Re: 7.3 and HEAD broken for dropped columns of dropped types
Date
Msg-id 009501c3182a$177013e0$6500a8c0@fhp.internal
Whole thread Raw
In response to 7.3 and HEAD broken for dropped columns of dropped types  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> I am thinking that it might be a good idea for ALTER TABLE DROP COLUMN
> to reset atttypid to zero in the dropped column's pg_attribute row.
> This would help catch any other places that are depending on a dropped
> column's atttypid to still be valid.  On the other hand, it would
> possibly confuse applications that are looking at pg_attribute.
> Comments anyone?

I think you should zero it - we keep finding these little places where we've
missed thinking about dropped columns and that should flush them out.  Any
application looking at the type of a dropped column is confused anyway...
(Or they're doing a join...which could result in the dropped column not
appearing in their result set but hey...)

Chris



pgsql-hackers by date:

Previous
From: "Andrew Dunstan"
Date:
Subject: Re: Plans for index names unique to a table?
Next
From: alex avriette
Date:
Subject: patch src/bin/psql/help.c