Re: Client build of MSVC6+ patch - Mailing list pgsql-patches

From Hiroshi Saito
Subject Re: Client build of MSVC6+ patch
Date
Msg-id 000b01c69a6d$ab536580$5a0f0dde@IBMC4B5932F74B
Whole thread Raw
In response to Re: Client build of MSVC6+ patch  ("Hiroshi Saito" <z-saito@guitar.ocn.ne.jp>)
Responses Re: Client build of MSVC6+ patch  (Bruce Momjian <bruce@momjian.us>)
Re: Client build of MSVC6+ patch  (Bruce Momjian <bruce@momjian.us>)
List pgsql-patches
Hi. Tom-san.

Oops, I understood it. Thank you for suggestion.
What condition is this?

Regards,
Hiroshi Saito

From: "Tom Lane"

> "Hiroshi Saito" <z-saito@guitar.ocn.ne.jp> writes:
>>> Why do we need to reorder the fields in the struct?
>
>> Eh? Even my FreeBSD used well shows a structure object.
>
> The standard lists the fields in the other order:
> http://www.opengroup.org/onlinepubs/009695399/basedefs/netdb.h.html
>
> Even though the standard doesn't say that that has to be the physical
> order, every other platform besides Windows does it that way.  The patch
> as given is unacceptable because it *will* break other platforms (mine
> for instance ;-)).  If it has to be this way for Windows then we need
> some sort of platform-specific #ifdef.  Considering that the code works
> as-is on several sorts of Windows builds, we probably need something
> even more specific than that, like #if MSVC-before-version-XX.
>
> regards, tom lane

Attachment

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: Client build of MSVC6+ patch
Next
From: ITAGAKI Takahiro
Date:
Subject: pgstattuple extension for indexes