Hi,
On 2026-06-02 20:08:17 +0200, Peter Eisentraut wrote:
> On 01.06.26 23:57, Andres Freund wrote:
> > Attached is an large incremental patch onto Bilal's version:
>
> This looks good to me.
Cool.
> (I suppose the 0005 patch was just for testing.
Correct. Things just take too long to iterate otherwise.
> The 0004 patch looks ok but
> could use some explanation in both the commit message and the code.)
It's also not really for commit at this point. I think we should do it, but it
to help more locally than on CI.
> + # FIXME: Should we also run on PRs?
>
> I don't know why we would, since we don't use them.
From what I can tell the workflow of plenty folks during their own development
is to open PRs in their own repo. I don't really see a downside to also
running on PRs, so I'm inclined to do so. Won't hurt us...
Greetings,
Andres Freund
