Re: Thread-safe nl_langinfo() and localeconv() - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Thread-safe nl_langinfo() and localeconv()
Date
Msg-id z4mc2hzecahyq3paupfsouhuupmzmgum45md3k5my6bmo7gvn7@z5j26doqamqy
Whole thread Raw
In response to Re: Thread-safe nl_langinfo() and localeconv()  (Peter Eisentraut <peter@eisentraut.org>)
List pgsql-hackers
Hi,

On 2025-03-28 09:13:54 +0100, Peter Eisentraut wrote:
> On 27.03.25 11:16, Peter Eisentraut wrote:
> > > Patch 0002 also looks okay, except that the error handling could be
> > > unified with existing code, as I had previously pointed out.  Patch
> > > 0005 fixes that.
> > 
> > I plan to commit this one next, after the above had a bit of time to stew.
> 
> also done

My compiler complains with:

[20/1982 42   1%] Compiling C object src/port/libpgport_shlib.a.p/pg_localeconv_r.c.o
../../../../../home/andres/src/postgresql/src/port/pg_localeconv_r.c:63:1: warning: ‘static’ is not at beginning of
declaration[-Wold-style-declaration]
 
   63 | const static struct lconv_member_info table[] = {
      | ^~~~~

This is the only such warning in the postgres tree.  I'll go and fix that.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: AIO v2.5
Next
From: Tom Lane
Date:
Subject: Re: SQLFunctionCache and generic plans