Hi,
On 2025-03-19 17:34:18 +1300, Thomas Munro wrote:
> On Wed, Mar 19, 2025 at 5:17 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > fe-auth-oauth-curl.c:1392:49: error: data argument not used by format string [-Werror,-Wformat-extra-args]
> > 1392 | actx_error(actx, "deleting kqueue timer: %m", timeout);
> > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
> > fe-auth-oauth-curl.c:324:59: note: expanded from macro 'actx_error'
> > 324 | appendPQExpBuffer(&(ACTX)->errbuf, libpq_gettext(FMT), ##__VA_ARGS__)
> > | ~~~ ^
> >
> > "timeout" isn't being used anymore.
>
> Yeah. Thanks, fixed.
>
> Now I'm wondering about teaching CI to fail on compiler warnings, ie
> not just the special warnings task but also in the Mac etc builds.
> The reason it doesn't is because it's sort of annoying to stop the
> main tests because of a format string snafu, but we must be able to
> put a new step at the end after all tests that scans the build logs
> for warning and then raises the alarm...
The best way would probably be to tee the output of the build to a log file
and then have a script at the end to check for errors in that.
Greetings,
Andres Freund
