Re: Why we need to check for local buffers in BufferIsExclusiveLocked and BufferIsDirty? - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Why we need to check for local buffers in BufferIsExclusiveLocked and BufferIsDirty?
Date
Msg-id vczvsdofiuvaahgkjiavqqa6ks7nynpxf6iangsk4lzgj2taer@yvuoi3pgxb6t
Whole thread Raw
List pgsql-hackers
Hi,

On 2024-12-05 18:38:16 +0530, Srinath Reddy Sadipiralla wrote:
> Why we need to check for local buffers in BufferIsExclusiveLocked and
> BufferIsDirty?,these 2 functions are called only from
> XlogRegisterBuffer,AFAIK which will be called only for permanent
> relations.Please correct me if i am wrong.

That's maybe true for in-core code today, but what guarantees that that's true
for the future? And what about code in extensions?

The gain by not dealing with local buffers in these functions is fairly small
too, so there's not really any reason for a change like yours.

- Andres



pgsql-hackers by date:

Previous
From: Tom Kincaid
Date:
Subject: Re: code contributions for 2024, WIP version
Next
From: Alvaro Herrera
Date:
Subject: Re: code contributions for 2024, WIP version