Re: Why our Valgrind reports suck - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Why our Valgrind reports suck
Date
Msg-id vcbwaa7wtojfkhrhmb6d6aexhf7l3mpwzud2defzifnvejlhlc@wh4mkk5bqpgc
Whole thread Raw
In response to Re: Why our Valgrind reports suck  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Why our Valgrind reports suck
List pgsql-hackers
Hi,

On 2025-05-22 21:48:24 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> >> But this is the last step to get to zero reported leaks in a run of the core
> >> regression tests, so let's do it.
> 
> > I assume that's just about the core tests, not more? I.e. I can't make skink
> > enable leak checking?
> 
> No, we're not there yet.  I've identified some other backend issues (in
> postgres_fdw in particular), and I've not looked at frontend programs
> at all.  For most frontend programs, I'm dubious how much we care.

Skink only tests backend stuff anyway, but the other backend issues make it a
no go for no...


> I'm envisioning this patch series as v19 work, were you
> thinking we should be more aggressive?

Mostly agreed - but I am wondering if the AV fix should be backpatched?

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: vignesh C
Date:
Subject: Random subscription 021_twophase test failure on kestrel
Next
From: Peter Geoghegan
Date:
Subject: Re: Why our Valgrind reports suck