Re: Fix outdated comments in catcache.h - Mailing list pgsql-hackers

From cca5507
Subject Re: Fix outdated comments in catcache.h
Date
Msg-id tencent_EDDA39847A1476D42EA528C834E2751E340A@qq.com
Whole thread Raw
In response to Re: Fix outdated comments in catcache.h  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: Fix outdated comments in catcache.h
List pgsql-hackers
Hi,

> > - dlist_node cache_elem; /* list member of per-catcache list */
> > + dlist_node cache_elem; /* list member of per-bucket list */
> 
> I'm not sure this is more informative. How about?
> 
> dlist_node cache_elem; /* member for CatCache.cc_lbucket[] dlist */
> 
> I also really wonder what the fascination with having lower-case
> struct names with camelCased typedef names in this file... It's not
> really clear if that comment should say "CatCache.cc_lbucket[]" or
> "catcache.cc_lbucket[]". I find the latter clearer so used that.

Your suggestion looks better, and we also need to update the comment
of CatCTup.cache_elem.

--
Regards,
ChangAo Chen

pgsql-hackers by date:

Previous
From: "Anders Åstrand"
Date:
Subject: Re: [Proposal] Generate pkg-config for server module development
Next
From: Dilip Kumar
Date:
Subject: Re: Proposal: Conflict log history table for Logical Replication