Re: BUG #19056: ExecInitPartitionExecPruning segfault due to NULL es_part_prune_infos - Mailing list pgsql-bugs

From feichanghong
Subject Re: BUG #19056: ExecInitPartitionExecPruning segfault due to NULL es_part_prune_infos
Date
Msg-id tencent_E6CAC49A0307E15909E4DD2DA3AA13E12305@qq.com
Whole thread Raw
In response to Re: BUG #19056: ExecInitPartitionExecPruning segfault due to NULL es_part_prune_infos  (Amit Langote <amitlangote09@gmail.com>)
Responses Re: BUG #19056: ExecInitPartitionExecPruning segfault due to NULL es_part_prune_infos
List pgsql-bugs


On Sep 18, 2025, at 09:33, Amit Langote <amitlangote09@gmail.com> wrote:

On Thu, Sep 18, 2025 at 7:32 AM David Rowley <dgrowleyml@gmail.com> wrote:
On Thu, 18 Sept 2025 at 09:43, David Rowley <dgrowleyml@gmail.com> wrote:
The first bad commit is:

commit bb3ec16e14ded1d23a46d3c7e623a965164fa124
Author: Amit Langote <amitlan@postgresql.org>
Date:   Thu Jan 30 11:57:32 2025 +0900

   Move PartitionPruneInfo out of plan nodes into PlannedStmt

I think the attached is the correct fix.  I also wonder if it's worth
an isolation test to exercise this code.

Thanks for the patch, David, and for the report, Fei.  I indeed forgot
to update EvalPlanQualStart() in that commit.

I agree about adding an isolation test, which I have done in the
attached updated patch.

Thanks David and Amit for the patch. It looks OK to me, and isolation
testing confirms the issue. Also, should s1ppx and s2ppx in the case be
renamed to s4ppx and s5ppx?

Best Regards,
Fei Changhong

pgsql-bugs by date:

Previous
From: Amit Langote
Date:
Subject: Re: BUG #19056: ExecInitPartitionExecPruning segfault due to NULL es_part_prune_infos
Next
From: Amit Langote
Date:
Subject: Re: BUG #19056: ExecInitPartitionExecPruning segfault due to NULL es_part_prune_infos