RE: Fix slotsync worker busy loop causing repeated log messages - Mailing list pgsql-hackers

Hi,

I have a small question about this:

```
@@ -1143,11 +1146,7 @@ SnapBuildProcessRunningXacts(SnapBuild *builder, XLogRecPtr lsn, xl_running_xact
      * our snapshot so others or we, after a restart, can use it.
      */
     if (builder->state < SNAPBUILD_CONSISTENT)
-    {
-        /* returns false if there's no point in performing cleanup just yet */
-        if (!SnapBuildFindSnapshot(builder, lsn, running))
-            return;
-    }
+        SnapBuildFindSnapshot(builder, lsn, running);
     else
         SnapBuildSerialize(builder, lsn);
```

Why we don't call SnapBuildSerialize() when reaching consistent
in SnapBuildFindSnapshot()? I think we can serialize the snapshot
if we are not building a full snapshot, at least.

--
Regards,
ChangAo Chen