> > > I would have considered adding an
> > > Assert(CheckRelationOidLockedByMe(relid, AccessShareLock, true))
> > > instead of the note, but that seems like overkill to me. So, I'm fine
> > > without it.
> >
> > An assertion is impossible to miss, acts as self-documentation and it
> > is not a performance critical path. A note at the top of the function
> > could be easily missed. I don't see why the note needs to mention the
> > case of a concurrent drop. So let's just keep the runtime check, then
> > drop the note, finally call it a day.
>
> Works for me. Thanks.
Fixed.
--
Regards,
ChangAo Chen
