Fix incorrect assertion in heapgettup_pagemode() - Mailing list pgsql-hackers

From cca5507
Subject Fix incorrect assertion in heapgettup_pagemode()
Date
Msg-id tencent_A84F3C810365BB9BD08442955AE494141907@qq.com
Whole thread Raw
Responses Re: Fix incorrect assertion in heapgettup_pagemode()
List pgsql-hackers
Hi,

diff --git a/src/backend/access/heap/heapam.c b/src/backend/access/heap/heapam.c
index 469397e7344..1229e22e78a 100644
--- a/src/backend/access/heap/heapam.c
+++ b/src/backend/access/heap/heapam.c
@@ -1077,7 +1077,7 @@ continue_page:
                        ItemId          lpp;
                        OffsetNumber lineoff;
 
-                       Assert(lineindex <= scan->rs_ntuples);
+                       Assert(lineindex < scan->rs_ntuples);
                        lineoff = scan->rs_vistuples[lineindex];
                        lpp = PageGetItemId(page, lineoff);
                        Assert(ItemIdIsNormal(lpp));

The lineindex is 0-based, so it should be '<' rather than '<=', thoughts?

--
Regards,
ChangAo Chen

Attachment

pgsql-hackers by date:

Previous
From: Alexander Korotkov
Date:
Subject: Re: Implement waiting for wal lsn replay: reloaded
Next
From: Erik Wienhold
Date:
Subject: Re: Regression with large XML data input