Request a Demo
Home   >   mailing lists

Re: [BUG] Incorrect historic snapshot may be serialized to disk during fast-forwarding - Mailing list pgsql-hackers

From cca5507
Subject Re: [BUG] Incorrect historic snapshot may be serialized to disk during fast-forwarding
Date
Msg-id tencent_95D13240784107B9768CA1DD851DB5B52908@qq.com
Whole thread Raw
In response to Re:[BUG] Incorrect historic snapshot may be serialized to disk during fast-forwarding  (ocean_li_996 <ocean_li_996@163.com>)
Responses Re:Re: [BUG] Incorrect historic snapshot may be serialized to disk during fast-forwarding
List pgsql-hackers
Tree view 
Hi Haiyang,

> The patch in attachment is better for me. What do you think?

The v2-0001 LGTM.

A small suggestion:

We should move the 'break' out of the 'if', because we don't want it fall through to XLOG_HEAP2_REWRITE if we are
fast-forwarding.

--
Regards,
ChangAo Chen

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Remove unused fields from BufferCacheNumaRec
Next
From: Chengpeng Yan
Date:
Subject: Re: tuple radix sort